Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add mempool filters and builder affinity #989

Merged
merged 1 commit into from
Feb 10, 2025
Merged

feat: add mempool filters and builder affinity #989

merged 1 commit into from
Feb 10, 2025

Conversation

dancoombs
Copy link
Collaborator

Closes #982

dancoombs
dancoombs commented Feb 1, 2025
View reviewed changes
dancoombs
dancoombs commented Feb 1, 2025
View reviewed changes
@codecov Codecov
Copy link

codecov bot commented Feb 1, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 72.81879% with 81 lines in your changes missing coverage. Please review.

Please upload report for BASE (feat/v0.6@1de53f0). Learn more about missing BASE report.

Files with missing lines Patch % Lines
crates/builder/src/emit.rs 27.02% 27 Missing ⚠️
crates/builder/src/task.rs 0.00% 10 Missing ⚠️
crates/pool/src/task.rs 0.00% 9 Missing ⚠️
bin/rundler/src/cli/mod.rs 0.00% 7 Missing ⚠️
crates/builder/src/bundle_proposer.rs 80.00% 5 Missing ⚠️
crates/pool/src/server/local.rs 0.00% 5 Missing ⚠️
crates/pool/src/server/remote/protos.rs 0.00% 5 Missing ⚠️
crates/pool/src/server/remote/server.rs 0.00% 4 Missing ⚠️
bin/rundler/src/cli/builder.rs 0.00% 3 Missing ⚠️
crates/builder/src/bundle_sender.rs 70.00% 3 Missing ⚠️
... and 2 more
Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
crates/pool/src/mempool/mod.rs 100.00% <100.00%> (ø)
crates/pool/src/mempool/paymaster.rs 93.75% <100.00%> (ø)
crates/pool/src/mempool/pool.rs 97.00% <100.00%> (ø)
crates/rpc/src/eth/api.rs 71.92% <100.00%> (ø)
crates/sim/src/simulation/mempool.rs 94.92% <100.00%> (ø)
crates/types/src/pool/traits.rs 100.00% <ø> (ø)
crates/types/src/pool/types.rs 45.00% <ø> (ø)
crates/pool/src/server/remote/client.rs 0.00% <0.00%> (ø)
crates/pool/src/mempool/uo_pool.rs 93.17% <98.76%> (ø)
bin/rundler/src/cli/builder.rs 0.00% <0.00%> (ø)
... and 9 more
Flag Coverage Δ
unit-tests 59.24% <72.81%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
rundler binary 0.00% <0.00%> (?)
builder 65.35% <0.00%> (?)
dev ∅ <0.00%> (?)
pool 67.70% <0.00%> (?)
provider 19.02% <0.00%> (?)
rpc 26.51% <0.00%> (?)
sim 77.59% <0.00%> (?)
tasks ∅ <0.00%> (?)
types 68.09% <0.00%> (?)
utils 32.43% <0.00%> (?)

@dancoombs dancoombs force-pushed the danc/affinity branch 3 times, most recently from 6793bb8 to 5fbe784 Compare February 1, 2025 18:22
0xfourzerofour
0xfourzerofour approved these changes Feb 3, 2025
View reviewed changes
Copy link
Collaborator

@0xfourzerofour 0xfourzerofour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overally looks good, I just think there should be some tests added

andysim3d
andysim3d previously approved these changes Feb 3, 2025
View reviewed changes
@dancoombs dancoombs force-pushed the danc/affinity branch 2 times, most recently from 3f42cff to 87218ff Compare February 4, 2025 23:59
0xfourzerofour
0xfourzerofour previously approved these changes Feb 5, 2025
View reviewed changes
Copy link
Collaborator

@0xfourzerofour 0xfourzerofour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@dancoombs dancoombs force-pushed the danc/submit-proxy branch 3 times, most recently from 48864f1 to 286d179 Compare February 7, 2025 14:47
Base automatically changed from danc/submit-proxy to feat/v0.6 February 10, 2025 15:39
@dancoombs dancoombs dismissed stale reviews from 0xfourzerofour and andysim3d February 10, 2025 15:39

The base branch was changed.

@dancoombs dancoombs merged commit 87c52f5 into feat/v0.6 Feb 10, 2025
11 checks passed
@dancoombs dancoombs deleted the danc/affinity branch February 10, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andysim3d andysim3d andysim3d approved these changes

@0xfourzerofour 0xfourzerofour 0xfourzerofour approved these changes

@dphilipson dphilipson Awaiting requested review from dphilipson dphilipson is a code owner

@alex-miao alex-miao Awaiting requested review from alex-miao alex-miao is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dancoombs @andysim3d @0xfourzerofour